Move freedBytes inside group reclaiming method #10375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Jul 3, 2024
| std::lock_guard<std::shared_mutex> exclusiveLock(arbitrationLock_); | ||
| getCandidateStats(&op); | ||
| uint64_t freedBytes = | ||
| reclaimFreeMemoryFromCandidates(&op, targetBytes, false); | ||
| reclaimFreeMemoryFromCandidates(&op, fastReclaimTargetBytes, false); |
There was a problem hiding this comment.
std::max(memoryPoolTransferCapacity_, requestBytes)? directly use it here?
| @@ -475,32 +475,34 @@ TEST_F(DateTimeFunctionsTest, yearDate) { | |||
| } | |||
|
|
|||
| TEST_F(DateTimeFunctionsTest, yearTimestampWithTimezone) { | |||
There was a problem hiding this comment.
Why we need this change? Thanks!
There was a problem hiding this comment.
We don't need this change. Some unrelated changes slips through. I'll delete them
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang merged this pull request in 562a7dc. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the freedBytes condition inside reclaiming method in shared arbitrator. At the same time rename targetBytes to requestBytes for future PR.