Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Linux release with adapters #10360

Closed
wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jul 1, 2024

This is a temporary workaround.
The actual fix is to build and install thrift.

Resolves #10352

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d9e7b18
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/668288ba746e740008eefc04

@pedroerp
Copy link
Contributor

pedroerp commented Jul 1, 2024

How did this get broken in the first place? What changed?

Cc: @kgpai @assignUser

@majetideepak
Copy link
Collaborator Author

@pedroerp The issue here has the details #10352

@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 4f532a0.

Copy link

Conbench analyzed the 1 benchmark run on commit 4f532a03.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Linux release with adapters is broken
3 participants