Add max spill level in RowNumber fuzzer #10347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Jun 28, 2024
| @@ -281,6 +283,7 @@ RowVectorPtr RowNumberFuzzer::execute( | |||
| if (injectSpill) { | |||
| spillDirectory = exec::test::TempDirectoryPath::create(); | |||
| builder.config(core::QueryConfig::kSpillEnabled, true) | |||
| .config(core::QueryConfig::kMaxSpillLevel, FLAGS_max_spill_level) | |||
There was a problem hiding this comment.
Can you randomize this in test instead of using a flag?
xiaoxmeng
approved these changes
Jul 1, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 6caa7d5. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a max spill level config in the RowNumberFuzzer.