Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate uses of legacy namespace folly::io::zlib (#10282) #10283

Closed
wants to merge 1 commit into from
Closed

migrate uses of legacy namespace folly::io::zlib (#10282) #10283

wants to merge 1 commit into from

Conversation

yfeldblum
Copy link
Contributor

Summary:

Migrate uses of legacy namespace folly::io::zlib to folly::compression::zlib.

Differential Revision: D58821426

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 58e2ebc
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66ac3d7a26745600081fe680

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jun 25, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
ddf3992 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jun 25, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
9410a15 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jun 28, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
16a8f9f 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jun 29, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
c597d5d 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr

Differential Revision: D58821426
pedroerp
pedroerp approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pedroerp
Copy link
Contributor

pedroerp commented Jul 1, 2024

@yfeldblum goes without saying, but please make sure this change is backwards compatible as oss builds are pinned on a slightly older version of folly.

pedroerp
pedroerp requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, seems like the changes are not backwards compatible? (removing the approval until we figure this out).

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jul 18, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
35e9e4c 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Jul 25, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
012347d 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp, skrueger

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Aug 1, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
12e2b54 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp, skrueger

Differential Revision: D58821426
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
58e2ebc 
…0283)

Summary:
Pull Request resolved: facebookincubator#10283

Pull Request resolved: facebookincubator#10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp, skrueger

Differential Revision: D58821426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

@stale Stale
Copy link

stale bot commented Nov 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Nov 4, 2024
@stale stale bot closed this Nov 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58821426

yfeldblum added a commit to yfeldblum/velox that referenced this pull request Dec 22, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (facebookincubator#1…
40cc1d5 
…0283)

Summary:


Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp, skrueger

Differential Revision: D58821426
facebook-github-bot pushed a commit that referenced this pull request Dec 22, 2024
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (#10283)
31a8e50 
Summary:


Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: michalgr, pedroerp, skrueger

Differential Revision: D58821426
facebook-github-bot pushed a commit that referenced this pull request Jan 18, 2025
@yfeldblum @facebook-github-bot
migrate uses of legacy namespace folly::io::zlib (#11929)
b78f46b 
Summary:
Pull Request resolved: #11929

Pull Request resolved: #10283

Pull Request resolved: #10282

Migrate uses of legacy namespace `folly::io::zlib` to `folly::compression::zlib`.

Reviewed By: sdruzkin, michalgr, pedroerp, skrueger

Differential Revision: D58821426

fbshipit-source-id: fc8f220660f64dca4887f8f1c816d88b98e28293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroerp pedroerp pedroerp requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yfeldblum @facebook-github-bot @pedroerp