Extend early dictionary assessment to all stripes #10131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
828d8a5 to
c978fa0
Compare
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 11, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Differential Revision: D58396478
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 11, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Differential Revision: D58396478
c978fa0 to
dfb4a0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 11, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Differential Revision: D58396478
dfb4a0e to
ae53ba4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 11, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Differential Revision: D58396478
ae53ba4 to
9a745b0
Compare
xiaoxmeng
approved these changes
Jun 11, 2024
| void DefaultFlushPolicy::setNextDictionaryCheckThreshold( | ||
| uint64_t stripeSizeEstimate) { | ||
| const auto increment = | ||
| stripeSizeThreshold_ / kNumDictionaryAssessmentsPerStripe; |
There was a problem hiding this comment.
Can you add a member say dictionaryCheckIncrement_? And
add VELOX_CHECK_GT(dictionaryCheckIncrement_, 0);
| return FlushDecision::EVALUATE_DICTIONARY; | ||
| if (stripeIndex_ < stripeProgress.stripeIndex) { | ||
| dictionaryCheckThreshold_ = 0; | ||
| setNextDictionaryCheckThreshold(); |
There was a problem hiding this comment.
SCOPE_EXIT{ setNextDictionaryCheckThreshold(stripeProgress.stripeSizeEstimate); };
if (stripeIndex_ < stripeProgress.stripeIndex) {
setNextDictionaryCheckThreshold();
}
if (stripeProgress.stripeSizeEstimate >= dictionaryCheckThreshold_) {
return FlushDecision::CHECK_DICTIONARY;
}
There was a problem hiding this comment.
This is more rigorous, but we only need to call it very rarely through the stripe instead of every batch written. I think of the current implementation as lazily incrementing the check threshold.
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 12, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Reviewed By: xiaoxmeng Differential Revision: D58396478
9a745b0 to
029a9a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 12, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Reviewed By: xiaoxmeng Differential Revision: D58396478
029a9a1 to
439e86f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Jun 12, 2024
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Reviewed By: xiaoxmeng Differential Revision: D58396478
439e86f to
fcbbe64
Compare
…10131) Summary: Pull Request resolved: facebookincubator#10131 Follow up diff to allow assessing dictionary early for all stripes. Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops. Reviewed By: xiaoxmeng Differential Revision: D58396478
|
This pull request was exported from Phabricator. Differential Revision: D58396478 |
fcbbe64 to
31a7586
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up diff to allow assessing dictionary early for all stripes.
Currently, this will cause continual invocation of abandonDictionaries for later stripes that are no-ops.
Differential Revision: D58396478