Add Spark raise_error function

[gaoyangxiaozhu]

This PR adds Spark raise_error function. It is re-used in Spark assert_true
function, so after this PR assert_true can also be supported.

Spark document: https://spark.apache.org/docs/latest/api/sql/#raise_error
Spark code: https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala#L85C1-L92C1
Issue: apache/incubator-gluten#5991

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	bc6b380
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/667e97e90817a60008bc9ed3

[gaoyangxiaozhu]

@rui-mo / @PHILO-HE help review

[rui-mo]

Thanks!

[gaoyangxiaozhu]

ping @rui-mo

[rui-mo]

Thanks.

[gaoyangxiaozhu]

I need @rui-mo for some input, @PHILO-HE please ignore my review refresh request before i update the code

[rui-mo]

Thanks!

[rui-mo]

Could you run the fuzzer test for this function to make sure it works? Thanks.

[gaoyangxiaozhu]

Could you run the fuzzer test for this function to make sure it works? Thanks.

Could you run the fuzzer test for this function to make sure it works? Thanks.

Could you run the fuzzer test for this function to make sure it works? Thanks.

I have verified locally end to end with gluten, @rui-mo what do you means for run fuzzer test for this function , does i need add a new fuzzer test or something , any reference ?

[rui-mo]

@gaoyangxiaozhu The command is like below, and you could use --only raise_error to test this function only.
https://github.com/facebookincubator/velox/blob/main/.github/workflows/scheduled.yml#L508-L512

[gaoyangxiaozhu]

--only raise_error

got! so it should be fine , a example local fuzzer run

[gaoyangxiaozhu]

@rui-mo any new comments ?

[rui-mo]

Thanks.

[rui-mo]

Thanks you.

[rui-mo]

Thanks. Looks good overall.

[rui-mo]

@gaoyangxiaozhu Could you try the fuzzer test again to make sure it works? Thanks.

[gaoyangxiaozhu]

@gaoyangxiaozhu Could you try the fuzzer test again to make sure it works? Thanks.
done.

[gaoyangxiaozhu]

ping @rui-mo / @PHILO-HE for follow up if has any new comments ？

[rui-mo]

@gaoyangxiaozhu I assume we need to rebase to #10274 and returns status in raise_error function after it gets merged. Thanks.

[gaoyangxiaozhu]

@gaoyangxiaozhu I assume we need to rebase to #10274 and returns status in raise_error function after it gets merged. Thanks.

sure, so could you help sign the PR or we need people from meta to review and help sign ?

[rui-mo]

@gaoyangxiaozhu Will continue to review this PR after the code is rebased to #10274. Thanks.

[rui-mo]

@gaoyangxiaozhu #10274 has been merged. Could you rebase to it and update the code? Thanks.

[gaoyangxiaozhu]

@gaoyangxiaozhu #10274 has been merged. Could you rebase to it and update the code? Thanks.

Done, and also local test with fuzze test. should be fine. @rui-mo

[PHILO-HE]

I have no other comment.

[rui-mo]

Thanks.

[facebook-github-bot]

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@bikramSingh91 merged this pull request in 4e39b06.

[conbench-facebook]

Conbench analyzed the 1 benchmark run on commit 4e39b06c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.