Remove fromTimeString function #10096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D58182255
Differential Revision: D58256397
Differential Revision: D58258211
Differential Revision: D58260593
Summary: Change 2 call sites in test to use fromTimestampString. Differential Revision: D58264094
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D58264094 |
|
This pull request has been merged in b3f53f6. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10096 Change 2 call sites in test to use fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58264094 fbshipit-source-id: 8a2e787c8960aa65cae98ba500e1872c5f0acac6
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10096 Change 2 call sites in test to use fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58264094 fbshipit-source-id: 8a2e787c8960aa65cae98ba500e1872c5f0acac6
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: facebookincubator#10096 Change 2 call sites in test to use fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58264094 fbshipit-source-id: 8a2e787c8960aa65cae98ba500e1872c5f0acac6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change 2 call sites in test to use fromTimestampString.
Differential Revision: D58264094