Fix HashStringAllocator::clear #10053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58171132 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Jun 5, 2024
| auto size = pair.second; | ||
| pool()->free(pair.first, size); | ||
| sizeFromPool_ -= size; | ||
| cumulativeBytes_ -= size; |
There was a problem hiding this comment.
Can we add a check in ~HashStringAllocator to verify both sizeFromPool_ and cumulativeBytes_ are zero to help us to catch this sort of problem in production? The downside is that we might see crash but we should fix anyway? Thanks!
xiaoxmeng
approved these changes
Jun 5, 2024
5d2744c to
b867fc4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58171132 |
Summary: Decrement memory counters as in HashStringAllocator::freeToPool Reviewed By: xiaoxmeng, mbasmanova Differential Revision: D58171132
b867fc4 to
da59897
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58171132 |
|
This pull request has been merged in 7fe89b4. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10053 Decrement memory counters as in HashStringAllocator::freeToPool Reviewed By: xiaoxmeng, mbasmanova Differential Revision: D58171132 fbshipit-source-id: f87d411022b9b5cd9d996b4d999a7ab6c485171b
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10053 Decrement memory counters as in HashStringAllocator::freeToPool Reviewed By: xiaoxmeng, mbasmanova Differential Revision: D58171132 fbshipit-source-id: f87d411022b9b5cd9d996b4d999a7ab6c485171b
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: facebookincubator#10053 Decrement memory counters as in HashStringAllocator::freeToPool Reviewed By: xiaoxmeng, mbasmanova Differential Revision: D58171132 fbshipit-source-id: f87d411022b9b5cd9d996b4d999a7ab6c485171b
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 29, 2024
Summary: This PR solves the following issues: 1. `cumulativeBytes_` is the counter of allocated bytes, if we allocate n blocks and then execute free() on these blocks, the final value of `cumulativeBytes_` should be equal to 0. But without this PR, the value of `cumulativeBytes_` is not equal to 0. see `HashStringAllocatorTest#multipleFreeAncCheckCumulativeBytes` test case in this PR. This is because we don't include the size of the `Header` when calculating the allocated bytes. 2. When executing `HashStringAllocator::clear()`, we need to decrement memory counters. PR #10053 only decrement memory counters when releasing `allocationsFromPool_`. We also need to decrement the memory counters when releasing memory requested by `memory::AllocationPool`. 3. After executing `HashStringAllocator::clear()`, the values of `cumulativeBytes_` and `sizeFromPool_` should be equal to 0. CC: xiaoxmeng mbasmanova Pull Request resolved: #10260 Reviewed By: Yuhta Differential Revision: D59065411 Pulled By: xiaoxmeng fbshipit-source-id: 8f7913b0b89de69f88fa4d606c9628b31be38e3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Decrement memory counters as in HashStringAllocator::freeToPool
Differential Revision: D58171132