Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Status return type for callNullable function API #10265

Closed
PHILO-HE opened this issue Jun 20, 2024 · 2 comments
Closed

Support Status return type for callNullable function API #10265

PHILO-HE opened this issue Jun 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PHILO-HE
Copy link
Contributor

Description

xxx/velox/functions/Registerer.h:74:51:   required from ‘bool facebook::velox::registerFunction(const std::vector<std::__cxx11::basic_string<char> >&, const std::vector<facebook::velox::exec::SignatureVariable>&, bool) [with Func = facebook::velox::functions::sparksql::RaiseErrorFunction; TReturn = facebook::velox::UnknownValue; TArgs = {facebook::velox::Varchar}]’
/velox/velox/functions/sparksql/Register.cpp:465:62:   required from here
/velox/./velox/core/SimpleFunctionMetadata.h:804:44: error: static assertion failed: UDF must implement at least one of `call`, `callNullable`, or `callNullFree` functions.
This error happens also if the output and input types of the functions do not match the
ones used in registration.
  804 |       udf_has_call || udf_has_callNullable || udf_has_callNullFree,
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/velox/./velox/core/SimpleFunctionMetadata.h:804:44: note: ‘((((bool)facebook::velox::core::UDFHolder<facebook::velox::functions::sparksql::RaiseErrorFunction<facebook::velox::exec::VectorExec>, facebook::velox::exec::VectorExec, facebook::velox::UnknownValue, facebook::velox::ConstantChecker<facebook::velox::Varchar
@mbasmanova
Copy link
Contributor

@PHILO-HE Thank you for creating this issue. It would nice to add support for Status to all flavors of 'call' API: https://velox-lib.io/blog/optimize-try-more#next-steps

@mbasmanova
Copy link
Contributor

CC: @rui-mo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants