Skip to content

Commit

Permalink
Fix documentation for TIMESTAMP_WITH_TIME_ZONE type (#9042)
Browse files Browse the repository at this point in the history
Summary:
TIMESTAMP_WITH_TIME_ZONE has been converted to a primitive type in #7480.

Update the documentation to match.

Pull Request resolved: #9042

Reviewed By: Yuhta

Differential Revision: D54885988

Pulled By: mbasmanova

fbshipit-source-id: 76a3a8cafbaf812ff7573816b57b1d1cde099471
  • Loading branch information
wypb authored and facebook-github-bot committed Mar 14, 2024
1 parent 399345d commit 3c47476
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions velox/docs/develop/types.rst
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,13 @@ Presto Type Physical Type
======================== =====================
HYPERLOGLOG VARBINARY
JSON VARCHAR
TIMESTAMP WITH TIME ZONE ROW<BIGINT, SMALLINT>
TIMESTAMP WITH TIME ZONE BIGINT
======================== =====================

TIMESTAMP WITH TIME ZONE represents a time point in milliseconds precision
from UNIX epoch with timezone information. Its physical type contains one 64-bit
signed integer for milliseconds and another 16-bit signed integer for timezone ID.
Valid range of timezone ID is [1, 1680], its definition can be found in ``TimeZoneDatabase.cpp``.
from UNIX epoch with timezone information. Its physical type is BIGINT.
The high 52 bits of bigint store signed integer for milliseconds in UTC.
Supported range of milliseconds is [0xFFF8000000000000L, 0x7FFFFFFFFFFFF]
(or [-69387-04-22T03:45:14.752, 73326-09-11T20:14:45.247]). The low 12 bits
store timezone ID. Supported range of timezone ID is [1, 1680].
The definition of timezone IDs can be found in ``TimeZoneDatabase.cpp``.

0 comments on commit 3c47476

Please sign in to comment.