-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Basic Authorization header #617
Fix Basic Authorization header #617
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
When it will be merged? |
@sergeymild You might use my fork https://github.com/ElfSundae/SocketRocket CocoaPods installation: pod 'SocketRocket', :git => 'https://github.com/ElfSundae/SocketRocket.git' Or: pod 'SocketRocket', :source => 'https://github.com/ElfSundae/CocoaPods-Specs.git' |
i can't use your fork, because i use it in a pod library, and as we know you can't use libraries from github they must be present in cocoapods repository((( |
Would be great if this can be merged, happy to help testing if needed! |
This PR fixes this issue on |
Currently the Basic Authorization header is always added.