Updated CI for dotnet indexer support #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
donsbot
requested changes
Nov 15, 2023
| chmod +x dotnet-install.sh | ||
| ./dotnet-install.sh --channel ${DOTNET} | ||
| export DOTNET_ROOT=$HOME/.dotnet | ||
| export PATH=$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools |
There was a problem hiding this comment.
Remove this line. We need to set the PATH to add these pieces in a different place.
It should be something like:
echo "$DOTNET_ROOT" >> "$GITHUB_PATH"
echo "$DOTNET_ROOT/tools" >> "$GITHUB_PATH"
the ci uses slightly different PATH variables due to how github does things.
There was a problem hiding this comment.
Alternatively, if we never need to use the dotnet command again, just invoke it via the full path.
$DOTNET_ROOT/dotnet ...
|
You need to rebase your branch over trunk, so that there are no conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.