Remove writeSubst

Summary: I don't remember what this was for, but we apparently don't use it.

Reviewed By: phlalx, josefs

Differential Revision: D68622344

fbshipit-source-id: 2d32c88f713a277d4c1bc089c76c7032ebcfbe4e

glean/db/Glean/Database/Types.hs

@@ -145,7 +145,6 @@ data Write = Write
 data WriteContent = WriteContent
   { writeBatch :: !Thrift.Batch
   , writeOwnership :: Maybe DefineOwnership
-  , writeSubst :: Subst -> Subst
   }
 
 -- | A Write on the WriteQueue

glean/db/Glean/Database/Write/Batch.hs

@@ -59,7 +59,6 @@ writeContentFromBatch :: Thrift.Batch -> WriteContent
 writeContentFromBatch writeBatch = WriteContent
   { writeBatch = writeBatch
   , writeOwnership = Nothing
-  , writeSubst = id
   }
 
 syncWriteDatabase

glean/db/Glean/Write/JSON.hs

@@ -48,20 +48,12 @@ import Glean.RTS.Builder
 import Glean.RTS.Set
 import Glean.RTS.Constants
 import qualified Glean.RTS.Foreign.JSON as J
-import Glean.RTS.Foreign.Subst as Subst (empty)
 import Glean.RTS.Types
 import Glean.Angle.Types hiding (Type)
 import Glean.Schema.Util
 import Glean.Types as Thrift hiding (Value, Nat, Byte)
 
 
--- just an empty Subst for now. Later we might implement
--- returning substitutions from JSON writes.
-emptySubst :: IO Batch -> IO WriteContent
-emptySubst batchIO = do
-  wc <- writeContentFromBatch <$> batchIO
-  return wc{writeSubst = const Subst.empty}
-
 syncWriteJsonBatch
   :: Env
   -> Repo
@@ -84,7 +76,7 @@ writeJsonBatch
   -> IO WriteContent
 writeJsonBatch env repo SendJsonBatch{..} = do
   dbSchema <- withOpenDatabase env repo (return . Database.odbSchema)
-  emptySubst $
+  writeContentFromBatch <$>
     buildJsonBatch dbSchema sendJsonBatch_options sendJsonBatch_batches
 
 buildJsonBatch