Move noscript tag to body element (#68)

Summary: This changeset updates the placement of the `noscript` pixel tag so that it is added within the `body` tag to keep the code valid HTML. Originally started in this PR: #35 Pull Request resolved: #68 Differential Revision: D68706167 Pulled By: vahidkay-meta fbshipit-source-id: a4211c11aa757ba4fbd8509699147ae5be9ce292
facebookincubator · Jan 27, 2025 · 69388b3 · 69388b3
1 parent 00df37e
commit 69388b3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/__tests__/core/FacebookWordpressPixelInjectionTest.php b/__tests__/core/FacebookWordpressPixelInjectionTest.php
@@ -79,7 +79,7 @@ public function testPixelInjection() {
       array( $injection_obj, 'inject_pixel_code' )
     );
     \WP_Mock::expectActionAdded(
-      'wp_head',
+      'wp_body_open',
       array( $injection_obj, 'inject_pixel_noscript_code' )
     );
 

diff --git a/core/class-aamfieldsextractor.php b/core/class-aamfieldsextractor.php
@@ -66,8 +66,14 @@ public static function get_normalized_user_data( $user_data_array ) {
     if (
         isset( $user_data_array[ AAMSettingsFields::DATE_OF_BIRTH ] )
         ) {
-        $unix_timestamp =
-        strtotime( $user_data_array[ AAMSettingsFields::DATE_OF_BIRTH ] );
+
+        $date_time      = \DateTime::createFromFormat(
+            'Y-m-d',
+            $user_data_array[ AAMSettingsFields::DATE_OF_BIRTH ],
+            new \DateTimeZone( 'GMT' )
+        );
+        $unix_timestamp = $date_time ? $date_time->getTimestamp() : false;
+
         if ( ! $unix_timestamp ) {
             unset( $user_data_array[ AAMSettingsFields::DATE_OF_BIRTH ] );
         } else {

diff --git a/core/class-facebookwordpresspixelinjection.php b/core/class-facebookwordpresspixelinjection.php
@@ -64,7 +64,7 @@ public function inject() {
                 array( $this, 'inject_pixel_code' )
             );
             add_action(
-                'wp_head',
+                'wp_body_open',
                 array( $this, 'inject_pixel_noscript_code' )
             );
             foreach (