Skip to content

Commit

Permalink
refactor: Consolidate subfield filter definitions (#2)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2

X-link: facebookincubator/velox#12184

There are multiple definitions of subfield filters in velox and consolidate them in Filter.h

Reviewed By: Yuhta

Differential Revision: D68719054

fbshipit-source-id: 7085c7ad803980d960e32ce4a981bd4a722558e9
  • Loading branch information
xiaoxmeng authored and facebook-github-bot committed Jan 28, 2025
1 parent c1b7d28 commit 2a6fdb8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion verax/connectors/hive/HiveConnectorMetadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ ConnectorTableHandlePtr HiveConnectorMetadata::createTableHandle(
}
auto dataColumns = ROW(std::move(names), std::move(types));
std::vector<core::TypedExprPtr> remainingConjuncts;
SubfieldFilters subfieldFilters;
common::SubfieldFilters subfieldFilters;
for (auto& typedExpr : filters) {
try {
auto pair = velox::exec::toSubfieldFilter(typedExpr, &evaluator);
Expand Down
2 changes: 1 addition & 1 deletion verax/tests/VeloxSql.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ class VeloxRunner {
const std::vector<std::string>& columnNames) {
using namespace connector::hive;
auto handle = std::make_shared<HiveTableHandle>(
kHiveConnectorId, name, true, SubfieldFilters{}, nullptr);
kHiveConnectorId, name, true, common::SubfieldFilters{}, nullptr);
std::unordered_map<std::string, std::shared_ptr<connector::ColumnHandle>>
assignments;

Expand Down

0 comments on commit 2a6fdb8

Please sign in to comment.