Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat + fix: bundle fixes and improvements on json files #852

Merged
merged 5 commits into from
Nov 5, 2023
Merged

feat + fix: bundle fixes and improvements on json files #852

merged 5 commits into from
Nov 5, 2023

Conversation

laresbernardo
Copy link
Collaborator

@laresbernardo laresbernardo commented Nov 4, 2023 •
edited
Loading

  • fix: restructure and clear usage of robyn_write() for 3 use cases: inputs only, models and inputs, outputs, models and inputs, depending on users inputs. Last scenario is used to replicate specific models.
  • fix: run timings on refresh models and robyn_run(... outputs = TRUE) now working
  • fix: get rid of some ":="s in the code (data.tables dependency)
  • fix: add "penalty" in HYPS_NAMES fixed vector

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2023
@laresbernardo
Copy link
Collaborator Author

Good to land and merge @gufengzhou

gufengzhou
gufengzhou approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gufengzhou gufengzhou merged commit 5a5f651 into facebookexperimental:main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @gufengzhou @facebook-github-bot