This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix build errors on real devices. #824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi infocube, thanks for the PR. Did you check if there's already a setting in one the xcconfigs that could be used to build armv7 and armv7s? |
|
Hi, Just fixed it, config in one file for all projects. |
|
Hm, so you're dropping armv6 in favor of armv7s support? Is armv7s already an issue? Three20 is probably used in 'legacy' projects, so a missing armv6 might be an issue for more users. What do you think? |
|
I am indifferent on the armv7 support but dropping armv6 is essential and the project currently does not compile for devices using Xcode 4.5 as armv6 compilation is no longer supported. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.