Improve compression ratio of the --patch-from mode #4288
Merged
+68
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--patch-from
mode essentially combines--long
with dictionary, in order to create a very small patch when compressing a new document based on an older revision of the same document.The
--long
mode features advanced parameters, that can be tuned by the user, but are rarely employed. As a consequence, the "default" values are almost always used, resulting in non-optimal performance.This patch dynamically updates the advanced parameters of the
--long
mode, spending more cpu time to favor compression ratio at higher levels.For illustration, here is an extract of the updated performance, using the following scenario:
zstd -# -T6 ~/dev/bench/linux-v6.13.tar --patch-from ~/dev/bench/linux-v6.12.tar
running on a ubuntu desktop with a i7-9700k cpu:
dev
timePR
timedev
cSizePR
cSize