Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual studio compilation tests: error out on warnings #4287

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Feb 5, 2025

Multiple minor warnings have accumulated over time due to CI tests silently accepting them.
Fixed in this PR.

@Cyan4973 Cyan4973 changed the title make visual studio tests error out on warnings visual studio compilation tests: error out on warnings Feb 5, 2025
seems like a prototype interface error:
input parameter should have been `const void*`,
since the documentation is explicit that input doesn't have to be aligned,
but `const __m256i*` makes the compiler enforce it.
this is a prototype definition error:
`_mm_storeu_si128()` should accept a `void*` pointer,
since it explicitly states that it accepts unaligned addresses
yet requiring a `__m128i*` tells otherwise, and requires the compiler the enforce this alignment.
which do not support `%zu` fields
@Cyan4973 Cyan4973 self-assigned this Feb 6, 2025
@Cyan4973 Cyan4973 marked this pull request as ready for review February 6, 2025 01:12
@Cyan4973 Cyan4973 merged commit 30e0f29 into dev Feb 6, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants