Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual + ClangCL + AVX2 compilation #4286

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Fix Visual + ClangCL + AVX2 compilation #4286

merged 3 commits into from
Feb 5, 2025

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Feb 5, 2025

Fix #4285

so that it doesn't depend on #include
when clang is used within msvc, `__GNUC__` isn't defined,
so testing `__clang__` explicitly is required.
@Cyan4973 Cyan4973 changed the title adding a Visual + ClangCL + AVX2 compilation test Fix Visual + ClangCL + AVX2 compilation Feb 5, 2025
@Cyan4973 Cyan4973 marked this pull request as ready for review February 5, 2025 23:30
@Cyan4973 Cyan4973 merged commit 8156a19 into dev Feb 5, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #4232 seems to break custom Chromium builds
3 participants