Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a Clang-CL Windows test to CI #3579

Merged
merged 1 commit into from
Mar 31, 2023
Merged

added a Clang-CL Windows test to CI #3579

merged 1 commit into from
Mar 31, 2023

Conversation

Cyan4973
Copy link
Contributor

If I understand correctly,
this should trigger the issue notified in #3569.

@Cyan4973 Cyan4973 mentioned this pull request Mar 29, 2023
Merged
@Cyan4973
Copy link
Contributor Author

Indeed, the Clang-CL test fails at link stage, as announced by #3569.

If that's correct, then merging #3569 and rebasing this PR on top of it should fix the issue.

@Cyan4973
added a Clang-CL Windows test to CI
0f77956 
If I understand correctly,
this should trigger the issue notified in #3569.
@Cyan4973
Copy link
Contributor Author

And yes, indeed, the new Clang-CL Windows test pass with #3569 fix.

That's one more build scenario that is now checked by GA CI.

@Cyan4973 Cyan4973 self-assigned this Mar 29, 2023
@Cyan4973 Cyan4973 merged commit f33a406 into dev Mar 31, 2023
@Cyan4973 Cyan4973 deleted the clangclwintest branch April 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cyan4973 Cyan4973

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyan4973 @facebook-github-bot