Mark Huffman Decoder Assembly noexecstack on All Architectures
#2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, even when the assembly file is empty (because `ZSTD_ENABLE_ASM_X86_64_BMI2` is false), it still is marked as possibly needing an executable stack and so the whole library is marked as such. This commit applies a simple patch for this problem by moving the noexecstack indication outside the macro guard. This commit builds on facebook#2857. This commit addresses facebook#2963.
Cyan4973
approved these changes
Dec 30, 2021
ce054ae to
35652b0
Compare
35652b0 to
35208f7
Compare
terrelln
reviewed
Jan 4, 2022
Hopefully this marks the binary artifacts `noexecstack` even on platforms where binaries default to true.
bd136c8 to
4620ce6
Compare
Previously we did this only on Linux, which missed other Unices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, even when the assembly file is empty (because
ZSTD_ENABLE_ASM_X86_64_BMI2is false), it still is marked as possibly needing an executable stack and so the whole library is marked as such. This commit applies a simple patch for this problem by moving the noexecstack indication outside the macro guard.In addition, this PR ships flags to the Makefile-driven builds to explicitly request a non-executable stack. This ought to be redundant, but it appears on at least one platform (MIPS) to succeed where the source code note fails.
This PR builds on #2857.
This PR addresses #2963.