Fix zstd-static output name with MINGW/Clang

[MehdiChinoune]

No description provided.

[facebook-github-bot]

Hi @MehdiChinoune!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[Cyan4973]

This seems to match the intention of the script,
which specifies that this library name should only be used with MSVC.

I'm surprised we can't rely solely on the MSVC detection, even when using the clang back end, but hey, that's a different problem.

[MehdiChinoune]

The problem is with #2877 where they tried to fix the issue #2248 which was the user fault who expect to get the same library name with clang in gnu mode, so instead of telling the user to use clang-cl which should be detected as MSVC they introduced this weird condition!