Add different dict modes to compression ratio regression test, update results.csv #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senhuang42
commented
Mar 25, 2021
| .cli_args = "-" #x, \ | ||
| .param_values = PARAM_VALUES(level_##x##_param_values_dictload), \ | ||
| .use_dictionary = 1, \ | ||
| .advanced_api_only = 1, \ |
There was a problem hiding this comment.
So I added the new configs to LEVEL() so we automatically get testing for all the levels we try.
An alternative approach is to have each of these just be their own config, with a fixed compression level (and if we wanted to test more clevels/strategies, we could just add more configs). But that does have the downside of not automatically hitting all the tested clevels.
I do prefer having these run on all the compression levels, in case in the future, strategies get changed in a way that might affect the dictionary strategies.
d980071 to
bbbd578
Compare
Cyan4973
approved these changes
Mar 25, 2021
terrelln
approved these changes
Mar 25, 2021
|
Thanks for adding this Sen! Really glad to see increased coverage of dictionary compression. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the row-hash PR, DMS was silently broken until recently fixed/discovered - our coverage of tests on different dict modes (DMS, DDS, Copy, Load) is not particularly high. This should be a good first step in ensuring we detect such things. (The row-hash PR adds a DMS unit test in fuzzer.c as well, to check for regressions)
This PR:
results.csvTesting: I tested this on row-hash with a broken DMS, and indeed the compression results were bad.