Fix dedicated dict search isSupported() requirements. #2540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, asserts in
zstd_lazy.c
will fail if you try to compress withchainLog > 24
orhLog < cLog
with dedicated dict search.The following command fails on
dev
:make -j zstd DEBUGLEVEL=1 && ./zstd [file] -D [dictFile] --zstd=clog=25,hlog=23 -7f
This PR adds the same checks that are
assert()
ed to be true inzstd_lazy.c
when using dedicated dict search, and includes a unit test that fails without this fix.Though, I will note that dedicated dict search at least seems to work fine when
clog > 24
orhLog < cLog
, so an alternative could just be to remove the asserts.