Add HUF_writeCTable_wksp() function #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2f0699 to
13e2dda
Compare
Cyan4973
reviewed
Mar 5, 2021
| @@ -732,7 +751,10 @@ static size_t HUF_compressCTable_internal( | |||
| typedef struct { | |||
| unsigned count[HUF_SYMBOLVALUE_MAX + 1]; | |||
| HUF_CElt CTable[HUF_SYMBOLVALUE_MAX + 1]; | |||
| HUF_buildCTable_wksp_tables buildCTable_wksp; | |||
| union { | |||
There was a problem hiding this comment.
unfortunately, nameless union is not a C90 feature.
There was a problem hiding this comment.
Bummer, I'll name it then
13e2dda to
5df2a21
Compare
This saves ~700 bytes of stack space in HUF_writeCTable.
Cyan4973
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves ~700 bytes of stack space in
HUF_writeCTable()by adding a workspace variant and using it in theHUF_compress_internal().