Seekable hang fix #2516
Merged
Seekable hang fix #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the issue described in #2506 of seekable decompression hanging.
ZSTD_seekable_decompress()may get stuck re-decompressing the input in an infinite loop (see line 451:targetFrame = ZSTD_seekable_offsetToFrameIndex(zs, zs->decompressedOffset);). I'm not aware of any valid reason to decompress more input than actually exists for seekable decompression in a singleZSTD_seekable_decompress()call, so we should check that we aren't reading too much input.Thanks @mlindsay for discovering issue!
Test Plan:
seekable_format/examples