Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal assembly functions are exported #2990

Closed
hjl-tools opened this issue Jan 11, 2022 · 0 comments
Closed

Internal assembly functions are exported #2990

hjl-tools opened this issue Jan 11, 2022 · 0 comments

Comments

@hjl-tools
Copy link
Contributor

On Linux/x86-64, Internal assembly functions are exported:

$ nm -D  lib/libzstd.so.1| grep usingDTable_internal_bmi2_asm_loop   
00000000000c23c0 T _HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c283d T _HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
00000000000c283d T HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop

These are internal functions and shouldn't be exported.
hjl-tools added a commit to hjl-tools/zstd that referenced this issue Jan 11, 2022
@hjl-tools
x86-64: Hide internal assembly functions
dfe79bf 
Hide x86-64 internal assembly functions. Before

$ nm -D lib/libzstd.so.1
00000000000c23c0 T _HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c283d T _HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
00000000000c283d T HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
$

After

$ nm -D lib/libzstd.so.1
$

This fixes issue facebook#2990.
@hjl-tools hjl-tools mentioned this issue Jan 11, 2022
Closed
hjl-tools added a commit to hjl-tools/zstd that referenced this issue Jan 11, 2022
@hjl-tools
x86-64: Hide internal assembly functions
b6c6891 
Hide x86-64 internal assembly functions. Before

$ nm -D lib/libzstd.so.1
00000000000c23c0 T _HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c283d T _HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
00000000000c283d T HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
$

After

$ nm -D lib/libzstd.so.1
$

This fixes issue facebook#2990.
@hjl-tools hjl-tools mentioned this issue Jan 11, 2022
Merged
hjl-tools added a commit to hjl-tools/zstd that referenced this issue Jan 11, 2022
@hjl-tools
x86-64: Hide internal assembly functions
568c69a 
Hide x86-64 internal assembly functions. Before

$ nm -D lib/libzstd.so.1 | grep usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T _HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c283d T _HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
00000000000c283d T HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
$

After

$ nm -D lib/libzstd.so.1 | grep usingDTable_internal_bmi2_asm_loop
$

This fixes issue facebook#2990.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjl-tools @felixhandte