Issue #779 Fix deprecation warnings #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
Aug 20, 2020
| @@ -71,7 +71,7 @@ def _read_project_github_hashes(): | |||
| for filename in files: | |||
| path = os.path.join(dirname, filename) | |||
| with open(path) as f: | |||
| m_proj = re.match('^' + base_dir + '(.*)-rev\.txt$', path) | |||
| m_proj = re.match('^' + base_dir + '(.*)-rev\\.txt$', path) | |||
There was a problem hiding this comment.
Can you revert this particular file from this PR?
It may sound like a weird request; fbcode_builder.py is a different project internally that is coincidentally mapped here when we export to github.
It has very opionated python version requirements and navigating those on the internal side of importing this PR could be a surprising amount of work, and none of it is related to or has benefit for watchman.
There was a problem hiding this comment.
Not a weird request at all. I reverted that file to the version in master.
There was a problem hiding this comment.
@wez has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
Summary: Pull Request resolved: facebookincubator/zstrong#850 Reviewed By: markbt Differential Revision: D58011866 fbshipit-source-id: 3c6a8443f7fd9c512837d27162a2399c21eb243c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #779 - Updates strings in several test files to properly escape backslashes.