This repository was archived by the owner on Feb 1, 2025. It is now read-only.
improve doc for runtime #367
Assignees
Comments
benjamn
added a commit
that referenced
this issue
Mar 7, 2019
In #353, I simplified the implementation of regenerator-runtime by converting runtime.js to a normal CommonJS module. No more global object detection, and no more sneaky capture/deletion of regeneratorRuntime. Unfortunately, folks who use only @babel/polyfill and not @babel/transform-runtime may have existing code that relies on a global regeneratorRuntime variable. That code will eventually disappear (:crossed-fingers:), but in the meantime we can continue supporting it by simply ensuring that regeneratorRuntime is defined globally as a side-effect of importing regenerator-runtime. This turns out to be much easier than detecting the global object, as long as runtime.js runs as a non-strict CommonJS module. See my code comments for another fallback solution that should cover all remaining cases. Background discussion: babel/babel#7646 (comment) Fixes #363. Fixes #337. Fixes #367.
benjamn
added a commit
that referenced
this issue
Mar 7, 2019
* Define regeneratorRuntime globally as a side-effect, again. In #353, I simplified the implementation of regenerator-runtime by converting runtime.js to a normal CommonJS module. No more global object detection, and no more sneaky capture/deletion of regeneratorRuntime. Unfortunately, folks who use only @babel/polyfill and not @babel/transform-runtime may have existing code that relies on a global regeneratorRuntime variable. That code will eventually disappear (:crossed_fingers:), but in the meantime we can continue supporting it by simply ensuring that regeneratorRuntime is defined globally as a side-effect of importing regenerator-runtime. This turns out to be much easier than detecting the global object, as long as runtime.js runs as a non-strict CommonJS module. See my code comments for another fallback solution that should cover all remaining cases. Background discussion: babel/babel#7646 (comment) Fixes #363. Fixes #337. Fixes #367. * Update regenerator/package-lock.json. * Fix Travis CI tests by running `npm i` instead of `npm ci`. * Prevent Travis from running `npm ci` by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
import 'regenerator-runtime/runtime' or require('regenerator-runtime/runtime') won't define a global regeneratorRuntime after 0.13
fix it or document it, please
The text was updated successfully, but these errors were encountered: