Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted a specific code for ie8 in CSSPropertyOperations #9296

Closed
wants to merge 1 commit into from

Conversation

Tom910
Copy link
Contributor

@Tom910 Tom910 commented Mar 30, 2017

React does not support ie8, so the code specific for IE was removed in CSSPropertyOperations.js

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aweary
Copy link
Contributor

aweary commented Mar 30, 2017

Hey @Tom910! Thanks for giving this a shot. I actually thought to do the same thing in #9294 but after some testing I found out that IE8 isn't the only browser that has trouble with these shorthand properties.

We'll have to do some more investigation and decide what browsers we want to support. We'll likely be able to remove a lot of this, but not all of it. Thanks for taking the time to do this though!

@aweary aweary closed this Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants