Transform keyMirror to object literal #7505
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping that avoiding
keyMirror
during load would have a more dramatic effect, but I can't tell if it's noise or not. The p90 didn't move, and I'm always reluctant to sell something solely based on averages.Results using the same benchmark from #7493 with 100 iterations:
It does result in some modest size improvements:
Given the low-impact of this PR, it won't hurt my feelings if it doesn't get merged.