Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Import warnings that currently live in gists. #7175

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

zpao
Copy link
Member

@zpao zpao commented Jul 2, 2016

The goal is to make it so we're not locked in to these existing as a gist on on any single person's account. This way if we want to make changes to the contents while 1 person is unavailable, it's totally doable. There are other ways we could solve that (easiest if we wanted to keep this on github is a standalone repo with each warning getting a file)

Downside: There is currently some discussion happening on the gists, which could be helpful and it's a slightly longer turnaround to updating the content. Not sure what we should do about that, if anything.

I grepped for all the unique fb.me links in master (15-stable matches) and opened all of them. These 4 were the ones that don't already link to some part of our docs (1 currently links to a specific issue which is probably ok). Only some minor changes were made to keep formatting and markdown consistency. We should probably do a pass over previous version (0.14, 0.13 should be enough) and do the same. I can do that if we want to take this.

@gaearon
Copy link
Collaborator

gaearon commented Jul 2, 2016

Downside: There is currently some discussion happening on the gists, which could be helpful

Tbh I think it’s confusing because we don’t get notified about it and mentions don’t work either. Let’s keep it here 👍

@zpao zpao force-pushed the warnings-in-docs branch from bde61c5 to a622e30 Compare July 5, 2016 20:46
@zpao
Copy link
Member Author

zpao commented Jul 5, 2016

Taking @gaearon's comment as an accept. I updated with the latest content from the unknown-prop gist and went back through 0.14 to ensure we didn't have anything there. I'll get this shipped and update the fb.me links to redirect appropriately.

@zpao zpao merged commit 26ed910 into facebook:master Jul 5, 2016
zpao added a commit that referenced this pull request Jul 5, 2016
usmanajmal pushed a commit to usmanajmal/react that referenced this pull request Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants