[Fiber] Simple test assertions #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll split the coroutine and incremental testing into their own tests so that I can expand them with more edge cases.
| beforeEach(function() { | ||
| React = require('React'); | ||
| ReactNoop = require('ReactNoop'); | ||
| ReactCoroutine = require('ReactCoroutine'); | ||
| spyOn(console, 'log'); | ||
| }); | ||
|
|
||
| it('should render a simple component', function() { |
There was a problem hiding this comment.
I thought these were commented out. :)
|
👍 |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
[Fiber] Simple test assertions (cherry picked from commit dc5686a)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
[Fiber] Simple test assertions (cherry picked from commit dc5686a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll split the coroutine and incremental testing into their own
tests so that I can expand them with more edge cases.