Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't wrap drag events in IE/Edge in dev builds" #6741

Merged
merged 1 commit into from
May 10, 2016

Conversation

sophiebits
Copy link
Collaborator

No description provided.

@sophiebits sophiebits merged commit 98cb2f8 into master May 10, 2016
@sophiebits sophiebits deleted the revert-6364-issue-5700 branch May 10, 2016 17:58
@gaearon
Copy link
Collaborator

gaearon commented May 10, 2016

If we used CommonJS, we could write a lint rule that prevents imports of renderer-specific parts in shared folders.

@zpao
Copy link
Member

zpao commented May 10, 2016

We could still write the rule but it would be gnarly. We could also actually get to the point where we ship distinct packages so then this wouldn't have worked at all…

@jimfb
Copy link
Contributor

jimfb commented May 12, 2016

This revert is effectively a breaking change, right? Or did the fix never ship to npm and so this would be a semver-minor also?

On a meta note, I feel like we should have fixed forward (refactored/moved code) rather than just immediately reverting without review.

@sophiebits
Copy link
Collaborator Author

It is not obvious to me how to fix forward; if you know how to do so cleanly I would appreciate a pull request. No, it only shipped in an alpha to npm.

@jimfb
Copy link
Contributor

jimfb commented May 12, 2016

Ok, so presumably that makes it semver-minor also?

@sophiebits
Copy link
Collaborator Author

It should go in the 15.1.0 release.

@jimfb jimfb added this to the 15.1.0 milestone May 12, 2016
zpao pushed a commit that referenced this pull request May 12, 2016
@zpao zpao modified the milestones: 15.1.0, 15.y.0 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants