Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint] Target ES5 #32420

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[eslint] Target ES5 #32420

merged 1 commit into from
Feb 18, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Feb 18, 2025

Update eslint-plugin-react-hooks to be built targetting ES5 instead. For various reasons our internal infra relies on these files being built already downleveled.

@poteto
[eslint] Target ES5
43b29ec 
Update eslint-plugin-react-hooks to be built targetting ES5 instead. For various reasons our internal infra relies on these files being built already downleveled.
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 18, 2025
@react-sizebot
Copy link

Comparing: 86b1913...da8efd6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.50 kB 110.49 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.30% 113.65 kB 134.44 kB +16.37% 22.56 kB 26.25 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.30% 113.65 kB 134.44 kB +16.37% 22.56 kB 26.25 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.28% 113.73 kB 134.53 kB +16.35% 22.60 kB 26.30 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.28% 113.73 kB 134.53 kB +16.35% 22.60 kB 26.30 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.25% 113.82 kB 134.60 kB +16.34% 22.58 kB 26.27 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.24% 113.91 kB 134.69 kB +16.31% 22.63 kB 26.32 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.30% 113.65 kB 134.44 kB +16.37% 22.56 kB 26.25 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.30% 113.65 kB 134.44 kB +16.37% 22.56 kB 26.25 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.28% 113.73 kB 134.53 kB +16.35% 22.60 kB 26.30 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.28% 113.73 kB 134.53 kB +16.35% 22.60 kB 26.30 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +18.25% 113.82 kB 134.60 kB +16.34% 22.58 kB 26.27 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +18.24% 113.91 kB 134.69 kB +16.31% 22.63 kB 26.32 kB

Generated by 🚫 dangerJS against 43b29ec

@poteto poteto merged commit a84862d into main Feb 18, 2025
196 checks passed
@poteto poteto deleted the pr32420 branch February 18, 2025 21:56
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@poteto
[eslint] Target ES5 (#32420)
c732f85 
Update eslint-plugin-react-hooks to be built targetting ES5 instead. For
various reasons our internal infra relies on these files being built
already downleveled.

DiffTrain build for [a84862d](a84862d)
@vercel-release-bot vercel-release-bot mentioned this pull request Feb 19, 2025
Closed
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Feb 19, 2025
@22388o
[eslint] Target ES5 (facebook#32420)
8121105 
Update eslint-plugin-react-hooks to be built targetting ES5 instead. For
various reasons our internal infra relies on these files being built
already downleveled.

DiffTrain build for [a84862d](facebook@a84862d)
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Feb 19, 2025
@22388o
[eslint] Target ES5 (facebook#32420)
14818a8 
Update eslint-plugin-react-hooks to be built targetting ES5 instead. For
various reasons our internal infra relies on these files being built
already downleveled.

DiffTrain build for [a84862d](facebook@a84862d)
This was referenced Feb 20, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot