[RN] Add support for document instance in React Native #32260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4c9609 to
73c3dad
Compare
|
Comparing: c492f97...a39a621 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
73c3dad to
5c88297
Compare
javache
approved these changes
Jan 29, 2025
Comment on lines
169
to
170
| // Remove the reference to the public instance to prevent memory leaks. | ||
| root.containerInfo.publicInstance = null; |
There was a problem hiding this comment.
Should this wait until after the updateContainer call?
5c88297 to
1d4d7e6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
Summary: This is a manual sync of facebook/react#32260 for internal testing Differential Revision: D68561175
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
## Summary We're adding support for `Document` instances in React Native (as `ReactNativeDocument` instances) in facebook/react-native#49012 , which requires the React Fabric renderer to handle its lifecycle. This modifies the renderer to create those document instances and associate them with the React root, and provides a new method for React Native to access them given its containerTag / rootTag. ## How did you test this change? Tested e2e in facebook/react-native#49012 manually syncing these changes. DiffTrain build for [b2357ec](b2357ec)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 29, 2025
## Summary We're adding support for `Document` instances in React Native (as `ReactNativeDocument` instances) in facebook/react-native#49012 , which requires the React Fabric renderer to handle its lifecycle. This modifies the renderer to create those document instances and associate them with the React root, and provides a new method for React Native to access them given its containerTag / rootTag. ## How did you test this change? Tested e2e in facebook/react-native#49012 manually syncing these changes. DiffTrain build for [b2357ec](facebook@b2357ec)
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're adding support for
Documentinstances in React Native (asReactNativeDocumentinstances) in facebook/react-native#49012 , which requires the React Fabric renderer to handle its lifecycle.This modifies the renderer to create those document instances and associate them with the React root, and provides a new method for React Native to access them given its containerTag / rootTag.
How did you test this change?
Tested e2e in facebook/react-native#49012 manually syncing these changes.