-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconciler: Combine identical cases in findParent #32210
Conversation
Based on the code I am currently debugging, see below code: react/packages/react-reconciler/src/ReactFiberCommitHostEffects.js Lines 408 to 414 in 221f300
react/packages/react-reconciler/src/ReactFiberCommitWork.js Lines 4860 to 4873 in 221f300
|
Can you edit your PR top comment to contain a description of what is changing and why? |
@gnoff Done, I haven't done more exploration on |
Comparing: a657bc5...3baa725 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
ty! |
## Summary When lookup `Parent`, `HostRoot` and `HostPortal` should be merged, because when creating a `Portal`, it will also include `containerInfo`(So we can directly use this `containerInfo` to delete the real DOM nodes.), so there is no need to handle them separately. ## How did you test this change? No behavior changes, all existing tests pass. DiffTrain build for [19ca800](19ca800)
## Summary When lookup `Parent`, `HostRoot` and `HostPortal` should be merged, because when creating a `Portal`, it will also include `containerInfo`(So we can directly use this `containerInfo` to delete the real DOM nodes.), so there is no need to handle them separately. ## How did you test this change? No behavior changes, all existing tests pass. DiffTrain build for [19ca800](19ca800)
Summary
When lookup
Parent
,HostRoot
andHostPortal
should be merged, because when creating aPortal
, it will also includecontainerInfo
(So we can directly use thiscontainerInfo
to delete the real DOM nodes.), so there is no need to handle them separately.How did you test this change?
No behavior changes, all existing tests pass.