[compiler] Remove redundant InferMutableContextVariables #32097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
josephsavona
approved these changes
Jan 21, 2025
| if ($[0] !== sharedVal) { | ||
| t0 = ( | ||
| <Button | ||
| onPress={() => (sharedVal.value = Math.random())} |
There was a problem hiding this comment.
seems like the check wasn't completely redundant since we are getting different output. why does this output change exactly?
There was a problem hiding this comment.
This is a similar case to the other test fixture (which also had changed output). From my opinion, we should be able to replace onPress={() => (sharedVal.value = Math.random())} with onPress={() => mutate(sharedVal)}, without meaningful changes to mutability inference.
This isn't the case today. InferMutableContextVariables annotates sharedVal has having a (known) "write", only because it sees a PropertyStore instruction. Without this, we infer sharedVal as only being captured by the function. This distinction doesn't really make sense with enableTransitivelyFreezeFunctionExpressions mode
There was a problem hiding this comment.
Ahhh makes sense. Cool
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
Small patch to pass aliased context values into `Object|ArrayExpression`s --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32093). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * #32094 * __->__ #32093
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32094). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * __->__ #32094 * #32093
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32095). * #32099 * #32104 * #32098 * #32097 * #32096 * __->__ #32095 * #32094 * #32093
This was referenced Feb 1, 2025
josephsavona
approved these changes
Feb 16, 2025
mofeiZ
added a commit
that referenced
this pull request
Feb 18, 2025
…ns (#32096) LoweredFunction dependencies were exclusively used for dependency extraction (in `propagateScopeDeps`). Now that we have a `propagateScopeDepsHIR` that recursively traverses into nested functions, we can delete `dependencies` and their associated synthetic `LoadLocal`/`PropertyLoad` instructions. [Internal snapshot diff](https://www.internalfb.com/phabricator/paste/view/P1716950202) for this change shows ~.2% of files changed. I [read through ~60 of the changed files](https://www.internalfb.com/phabricator/paste/view/P1733074307) - most changes are due to better outlining (due to better DCE) - a few changes in memo inference are due to changed ordering ``` // source arr.map(() => contextVar.inner); // previous instructions $0 = LoadLocal arr $1 = $0.map // Below instructions are synthetic $2 = LoadLocal contextVar $3 = $2.inner $4 = Function deps=$3 context=contextVar { ... } ``` - a few changes are effectively bugfixes (see `aliased-nested-scope-fn-expr`) --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32096). * #32099 * #32286 * #32104 * #32098 * #32097 * __->__ #32096
This removes special casing for `PropertyStore` mutability inference within FunctionExpressions.
mofeiZ
added a commit
that referenced
this pull request
Feb 18, 2025
(title) --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32098). * #32287 * #32104 * __->__ #32098 * #32097
mofeiZ
added a commit
that referenced
this pull request
Feb 18, 2025
(title) --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32104). * #32287 * __->__ #32104 * #32098 * #32097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes special casing for
PropertyStoremutability inference within FunctionExpressions.Stack created with Sapling. Best reviewed with ReviewStack.