fix[DevTools]: support useResourceEffect #32088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 89dbd48...63b43bc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jackpope
approved these changes
Jan 16, 2025
hoxyq
commented
Jan 16, 2025
| @@ -943,6 +962,10 @@ function parseHookName(functionName: void | string): string { | |||
| startIndex += 'unstable_'.length; | |||
| } | |||
|
|
|||
| if (functionName.slice(startIndex).startsWith('unstable_')) { | |||
There was a problem hiding this comment.
Oops, missed this one
hoxyq
added a commit
that referenced
this pull request
Jan 22, 2025
…support (#32106) - Adds support for `experimental_useEffectEvent`, now DevTools will be able to display this hook for inspected element - Added a use case to DevTools shell, couldn't add case, because we are using ReactTestRenderer, which has the corresponding flag disabled. - Forward-fix logic for handling `experimental` prefix that was added in #32088. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've started experimenting with it, I've started seeing a spike in errors:
Adding missing hook to the
Dispatcherthat is proxied by React DevTools.I can't really add an example that will use it to our RDT testing shell, because it uses experimental builds of
react, which don't have this hook. I've tested it manually by rebuilding artifacts withenableUseResourceEffectHookflag enabled.