Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot for pr notifications #31985

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

rickhanlonii
Copy link
Member

Going to take some testing to get this right

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 8:33pm

@react-sizebot
Copy link

react-sizebot commented Jan 6, 2025

Comparing: e0c893f...21ae3fb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 513.40 kB 512.56 kB = 91.72 kB 91.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 518.18 kB 517.34 kB = 92.57 kB 92.46 kB
facebook-www/ReactDOM-prod.classic.js = 595.45 kB 594.36 kB = 104.81 kB 104.69 kB
facebook-www/ReactDOM-prod.modern.js = 585.72 kB 584.62 kB = 103.25 kB 103.14 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactART-prod.classic.js = 367.66 kB 366.83 kB = 61.51 kB 61.40 kB
facebook-www/ReactART-dev.classic.js = 650.42 kB 648.92 kB = 103.49 kB 103.22 kB
facebook-www/ReactART-prod.modern.js = 357.94 kB 357.10 kB = 59.94 kB 59.80 kB
facebook-www/ReactART-dev.modern.js = 640.54 kB 639.04 kB = 101.53 kB 101.24 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 553.64 kB 552.34 kB = 90.03 kB 89.74 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 553.60 kB 552.30 kB = 90.02 kB 89.72 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 553.57 kB 552.27 kB = 90.01 kB 89.71 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 312.78 kB 311.93 kB = 54.81 kB 54.62 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js = 312.61 kB 311.76 kB = 54.78 kB 54.59 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js = 312.53 kB 311.69 kB = 54.76 kB 54.57 kB

Generated by 🚫 dangerJS against 0f157c4

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of only creating these notifications once PRs are marked as ready for review? This could allow "pinging" the channel again by marking PRs as draft/ready-for-review again which doesn't sound too bad?

@rickhanlonii
Copy link
Member Author

@eps1lon not sure anyone really uses the 'ready for review" workflow. The goal here is to mirror the bot we've used for years internally

@rickhanlonii
Copy link
Member Author

@eps1lon ready for review! lol

@rickhanlonii rickhanlonii requested a review from eps1lon January 6, 2025 20:34
@rickhanlonii rickhanlonii merged commit 3314162 into facebook:main Jan 6, 2025
190 checks passed
@rickhanlonii rickhanlonii deleted the rh/discord-bot branch January 7, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants