[compiler] Bail out on local variables named 'fbt' #30524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mofeiZ
added a commit
that referenced
this pull request
Jul 30, 2024
ghstack-source-id: c4e2b802a029b9dd7941ebcdeaaf471ddd95f868 Pull Request resolved: #30524
mofeiZ
commented
Jul 30, 2024
| @@ -311,6 +311,12 @@ export default class HIRBuilder { | |||
| } | |||
|
|
|||
| resolveBinding(node: t.Identifier): Identifier { | |||
| if (node.name === 'fbt') { | |||
There was a problem hiding this comment.
We could also bail out when fbt is not directly imported, but that's not necessary as we only rename locals within functions the compiler processes
mvitousek
approved these changes
Jul 30, 2024
josephsavona
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
mofeiZ
added a commit
that referenced
this pull request
Jul 30, 2024
ghstack-source-id: c4e2b802a029b9dd7941ebcdeaaf471ddd95f868 Pull Request resolved: #30524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See #30523