Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert getEventKey-test to createRoot #28006

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Convert getEventKey-test to createRoot #28006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 33 additions & 14 deletions packages/react-dom/src/events/__tests__/getEventKey-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,45 @@
'use strict';

let React;
let ReactDOM;
let ReactDOMClient;

let act;

describe('getEventKey', () => {
let container;
let root;

beforeEach(() => {
React = require('react');
ReactDOM = require('react-dom');
ReactDOMClient = require('react-dom/client');

act = require('internal-test-utils').act;

// The container has to be attached for events to fire.
container = document.createElement('div');
root = ReactDOMClient.createRoot(container);
document.body.appendChild(container);
});

afterEach(() => {
document.body.removeChild(container);
container = null;
root = null;
});

describe('when key is implemented in a browser', () => {
describe('when key is not normalized', () => {
it('returns a normalized value', () => {
it('returns a normalized value', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyDown={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keydown', {
key: 'Del',
Expand All @@ -52,15 +61,17 @@ describe('getEventKey', () => {
});

describe('when key is normalized', () => {
it('returns a key', () => {
it('returns a key', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyDown={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keydown', {
key: 'f',
Expand All @@ -76,15 +87,17 @@ describe('getEventKey', () => {
describe('when key is not implemented in a browser', () => {
describe('when event type is keypress', () => {
describe('when charCode is 13', () => {
it('returns "Enter"', () => {
it('returns "Enter"', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyPress={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keypress', {
charCode: 13,
Expand All @@ -97,15 +110,17 @@ describe('getEventKey', () => {
});

describe('when charCode is not 13', () => {
it('returns a string from a charCode', () => {
it('returns a string from a charCode', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyPress={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keypress', {
charCode: 65,
Expand All @@ -120,15 +135,17 @@ describe('getEventKey', () => {

describe('when event type is keydown or keyup', () => {
describe('when keyCode is recognized', () => {
it('returns a translated key', () => {
it('returns a translated key', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyDown={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keydown', {
keyCode: 45,
Expand All @@ -141,15 +158,17 @@ describe('getEventKey', () => {
});

describe('when keyCode is not recognized', () => {
it('returns Unidentified', () => {
it('returns Unidentified', async () => {
let key = null;
class Comp extends React.Component {
render() {
return <input onKeyDown={e => (key = e.key)} />;
}
}

ReactDOM.render(<Comp />, container);
await act(() => {
root.render(<Comp />);
});

const nativeEvent = new KeyboardEvent('keydown', {
keyCode: 1337,
Expand Down