[DevTools] Modify DevTools e2e test script for regression tests #24642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: f534cc6...d361359 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
reviewed
May 31, 2022
| 'yarn', | ||
| [ | ||
| 'cross-env', | ||
| 'REACT_VERSION=16.8', |
There was a problem hiding this comment.
Did you mean to hard-code the React version? I assume it was an accident.
bvaughn
approved these changes
May 31, 2022
a07dec6 to
88dc811
Compare
88dc811 to
d361359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the
run_devtools_e2e_testsscript so that you can pass in a React version. If you pass in a version, it will build the DevTools shell and run the e2e tests with that version.