Remove react-dom OSS testing builds #18138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41d60f4:
|
The testing build versions of react-dom are included in the builds right now, but we're not ready to share them yet. This PR removes them for now (back soon for the next release)
9e81244 to
41d60f4
Compare
trueadm
approved these changes
Feb 26, 2020
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 2, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes some tests in TestUtilsAct to reflect this
Closed
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 2, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes some tests in TestUtilsAct to reflect this
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 2, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 2, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 3, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 3, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for react as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 3, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for react as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 3, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for react as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 4, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for react as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 4, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - reintroduces the `isTestEnvironment`feature flag. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for react as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 4, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - introduces the `__TESTING__` global. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for `react` as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Mar 4, 2020
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - introduces the `__TESTING__` global. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for `react` as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing build versions of react-dom are included in the OSS builds right now, but we're not ready to share them yet. This PR removes them for now (back soon for the next release).
Do your magic, CI.