Rename toWarnDev -> toErrorDev, toLowPriorityWarnDev -> toWarnDev #17605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #17599.
Part of #16753.
This renames the matchers to match the console method names, now that we use console directly:
toWarnDev
->toErrorDev
(because it capturesconsole.error
calls)toLowPriorityWarnDev
->toWarnDev
(because it capturesconsole.warn
calls)I initially considered more explicit names like
toConsoleErrorDev
but it's annoying when it's used so much. Arguably there could be some confusion betweentoThrow
andtoErrorDev
, but the*Dev
suffix in my opinion is sufficient to remember which one does what.