Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Better compat with http.createServer #17289

Merged
merged 1 commit into from
Nov 6, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions packages/react-server/src/ReactServerHostConfigNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@

import type {Writable} from 'stream';

type MightBeFlushable = {flush?: () => void};
type MightBeFlushable = {
flush?: () => void,
flushHeaders?: () => void, // Legacy
};

export type Destination = Writable & MightBeFlushable;

Expand All @@ -21,13 +24,20 @@ export function flushBuffered(destination: Destination) {
// If we don't have any more data to send right now.
// Flush whatever is in the buffer to the wire.
if (typeof destination.flush === 'function') {
// By convention the Zlib streams provide a flush function for this purpose.
destination.flush();
// http.createServer response have flush(), but it has a different meaning and
// is deprecated in favor of flushHeaders(). Detect to avoid a warning.
if (typeof destination.flushHeaders !== 'function') {
// By convention the Zlib streams provide a flush function for this purpose.
destination.flush();
}
}
}

export function beginWriting(destination: Destination) {
destination.cork();
// Older Node streams like http.createServer don't have this.
if (typeof destination.cork === 'function') {
destination.cork();
}
}

export function writeChunk(destination: Destination, buffer: Uint8Array) {
Expand All @@ -36,7 +46,10 @@ export function writeChunk(destination: Destination, buffer: Uint8Array) {
}

export function completeWriting(destination: Destination) {
destination.uncork();
// Older Node streams like http.createServer don't have this.
if (typeof destination.uncork === 'function') {
destination.uncork();
}
}

export function close(destination: Destination) {
Expand Down