Rename findHostInstance_deprecated to findHostInstance_DEPRECATED #17228
+26
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. 👍 |
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Oct 30, 2019
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Oct 31, 2019
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yungsters wants this to be
_DEPRECATEDto be more obnoxious than the lower case version. It's also more consistent with our internal files that we deprecate. React also has methods prefixed withUNSAFE_so the all caps seem reasonable.