Update release scripts to support experimental releases #17086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental builds should pull artifacts from the `process_artifacts_experimental` job. I think instead of two separate CI workflows, a better approach might be to build stable artifacts to the `build` directory and the experimental artifacts to a `build_experimental` directory, and generate both within the same workflow. This would take some work since lots of things assume the output directory is `build`, but something to consider in the future.
Adds a check to the `prepare-stable` script to prevent experimental builds from being published using stable semver versions.
bvaughn
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the
prepare-stablescript to prevent experimental builds from being published using stable semver versions.Also updates the function that downloads the artifacts to pull from the correct CI job. I think instead of two separate CI workflows, a better approach might be to build stable artifacts to the
builddirectory and the experimental artifacts to abuild_experimentaldirectory, and generate both within the same workflow. This would take some work since lots of things assume the output directory isbuild, but something to consider in the future.Test plan
Run
and confirm that it exits with an error message.