Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename experimental react-ui => react-interactions #16842

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Rename experimental react-ui => react-interactions #16842

merged 1 commit into from
Sep 20, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 20, 2019 •
edited
Loading

Neither is intended as an actual name. It's a placeholder.

But ReactUI is something we might actually wanna use in the future. Using it as a codename now can make it more difficult to use later "for real". As we know, codenames leak and get a life of their own.

Is react-interactions the perfect name? No. But that's the point. If we started using it as a codename, let's keep it that way. And I guess it's OK to put windowing stuff there too until we figure out another place for it.

@sizebot
Copy link

sizebot commented Sep 20, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 57a5805...26ece98

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js n/a n/a 0 B 10.93 KB 0 B 2.36 KB UMD_DEV
react-interactions-events/press.development.js n/a n/a 0 B 5.03 KB 0 B 1.43 KB UMD_DEV
react-interactions-events/tap.development.js n/a n/a 0 B 17.5 KB 0 B 3.75 KB UMD_DEV
react-interactions-events/focus.production.min.js n/a n/a 0 B 4.1 KB 0 B 1.39 KB UMD_PROD
react-interactions-events/press.production.min.js n/a n/a 0 B 2.25 KB 0 B 984 B UMD_PROD
react-interactions-events/tap.production.min.js n/a n/a 0 B 6.19 KB 0 B 2.34 KB UMD_PROD
react-interactions-events/context-menu.development.js n/a n/a 0 B 2.68 KB 0 B 1007 B UMD_DEV
react-interactions-events/input.development.js n/a n/a 0 B 4.52 KB 0 B 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js n/a n/a 0 B 6.3 KB 0 B 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js n/a n/a 0 B 1.39 KB 0 B 729 B UMD_PROD
react-interactions-events/input.production.min.js n/a n/a 0 B 1.84 KB 0 B 984 B UMD_PROD
react-interactions-events/scroll.production.min.js n/a n/a 0 B 2.63 KB 0 B 1.15 KB UMD_PROD
react-interactions-events/context-menu.development.js n/a n/a 0 B 2.49 KB 0 B 960 B NODE_DEV
react-interactions-events/input.development.js n/a n/a 0 B 4.34 KB 0 B 1.4 KB NODE_DEV
react-interactions-events/scroll.development.js n/a n/a 0 B 6.12 KB 0 B 1.61 KB NODE_DEV
react-interactions-accessibility/tab-focus.development.js n/a n/a 0 B 4.79 KB 0 B 1.25 KB NODE_DEV
react-interactions-events/context-menu.production.min.js n/a n/a 0 B 1.2 KB 0 B 669 B NODE_PROD
react-interactions-events/input.production.min.js n/a n/a 0 B 1.66 KB 0 B 917 B NODE_PROD
react-interactions-events/scroll.production.min.js n/a n/a 0 B 2.44 KB 0 B 1.09 KB NODE_PROD
react-interactions-accessibility/tab-focus.production.min.js n/a n/a 0 B 1.79 KB 0 B 856 B NODE_PROD
react-interactions-events/hover.development.js n/a n/a 0 B 7 KB 0 B 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js n/a n/a 0 B 20.74 KB 0 B 4.83 KB UMD_DEV
react-interactions-events/hover.production.min.js n/a n/a 0 B 3.12 KB 0 B 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js n/a n/a 0 B 6.98 KB 0 B 2.63 KB UMD_PROD
react-interactions-events/hover.development.js n/a n/a 0 B 6.82 KB 0 B 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js n/a n/a 0 B 20.55 KB 0 B 4.78 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js n/a n/a 0 B 6.86 KB 0 B 1.64 KB NODE_DEV
react-interactions-events/hover.production.min.js n/a n/a 0 B 2.94 KB 0 B 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js n/a n/a 0 B 6.8 KB 0 B 2.57 KB NODE_PROD
react-interactions-accessibility/focus-table.production.min.js n/a n/a 0 B 2.3 KB 0 B 1004 B NODE_PROD
react-interactions-events/focus.development.js n/a n/a 0 B 10.74 KB 0 B 2.32 KB NODE_DEV
react-interactions-events/press.development.js n/a n/a 0 B 4.74 KB 0 B 1.36 KB NODE_DEV
react-interactions-events/tap.development.js n/a n/a 0 B 17.32 KB 0 B 3.69 KB NODE_DEV
react-interactions-events/focus.production.min.js n/a n/a 0 B 3.93 KB 0 B 1.33 KB NODE_PROD
react-interactions-events/press.production.min.js n/a n/a 0 B 1.96 KB 0 B 889 B NODE_PROD
react-interactions-events/tap.production.min.js n/a n/a 0 B 6.03 KB 0 B 2.28 KB NODE_PROD
react-interactions-events/drag.development.js n/a n/a 0 B 5.23 KB 0 B 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js n/a n/a 0 B 5.75 KB 0 B 2.14 KB UMD_DEV
react-interactions-events/swipe.development.js n/a n/a 0 B 6 KB 0 B 1.63 KB UMD_DEV
react-interactions-events/drag.production.min.js n/a n/a 0 B 2.25 KB 0 B 1.07 KB UMD_PROD
react-interactions-events/keyboard.production.min.js n/a n/a 0 B 2.41 KB 0 B 1.21 KB UMD_PROD
react-interactions-events/swipe.production.min.js n/a n/a 0 B 2.45 KB 0 B 1.11 KB UMD_PROD
react-interactions-events/drag.development.js n/a n/a 0 B 6.98 KB 0 B 2.21 KB NODE_DEV
react-interactions-events/keyboard.development.js n/a n/a 0 B 5.57 KB 0 B 2.1 KB NODE_DEV
react-interactions-events/swipe.development.js n/a n/a 0 B 5.82 KB 0 B 1.58 KB NODE_DEV
react-interactions-accessibility/tabbable-scope.development.js n/a n/a 0 B 1.18 KB 0 B 584 B NODE_DEV
react-interactions-events/drag.production.min.js n/a n/a 0 B 2.88 KB 0 B 1.38 KB NODE_PROD
react-interactions-events/keyboard.production.min.js n/a n/a 0 B 2.23 KB 0 B 1.16 KB NODE_PROD
react-interactions-events/swipe.production.min.js n/a n/a 0 B 2.27 KB 0 B 1.05 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js n/a n/a 0 B 680 B 0 B 447 B NODE_PROD

Generated by 🚫 dangerJS against 26ece98

trueadm
trueadm approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming doensn't bother me that much, it's all experimental stuff anyway.

@gaearon gaearon merged commit cef47cb into facebook:master Sep 20, 2019
@gaearon gaearon deleted the not-react-ui branch September 20, 2019 10:51
@sophiebits
Copy link
Collaborator

Thanks for saving the reactui name!

@oliviertassinari oliviertassinari mentioned this pull request Sep 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@necolas necolas Awaiting requested review from necolas

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaearon @sizebot @sophiebits @trueadm @facebook-github-bot